Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep reference to original module in LazyLoadModule #439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Keep reference to original module in LazyLoadModule #439

wants to merge 1 commit into from

Commits on Mar 4, 2021

  1. Keep reference to original module in LazyLoadModule 

    This is so all values in __dict__ of original module are not set to None by the module destructor when sys.modules[name] is the last reference to the original module, and is replaced during LazyLoadModule.__init__. This prevents any problems where another reference to the original module exists (such as in a PEP-302 loader).

This is a somewhat obscure problem, but I did encounter it as I am using a PEP-302 loader in Maya, and it took a couple of days to figure out. I have updated the loader to ensure no reference to the module is kept during module execution, but this also seems like a useful update to pymel.
    @GlenWalker
    GlenWalker authored Mar 4, 2021
    Configuration menu
    Copy the full SHA
    8b69b72 View commit details
    Browse the repository at this point in the history