Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tearsheet without display #428

Merged
merged 16 commits into from
Apr 17, 2024
Merged

Conversation

ishapiro
Copy link
Collaborator

Adds support for a new option save_tearsheet. When this option is set to True the tearsheet will be saved even if the show_tearsheet option is set to false.

@ishapiro ishapiro requested a review from grzesir as a code owner April 16, 2024 19:28
Copy link
Contributor

korbit-ai bot commented Apr 16, 2024

My review is in progress 📖 - I will have feedback for you in a few minutes!

Copy link
Contributor

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code and did not find any issues!


Please note that I can make mistakes, and you should still encourage your team to review your code as well.

@grzesir grzesir merged commit fce4b08 into dev Apr 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants