Improve trim extension support #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This query is part of the VK_KHR_display wsi extension and should not be replayed because the X11 Display connection cannot be remapped. Change-Id: I6780dd46b31017ef6879e218801c10748de079e0
Add mutable_type array to DescriptorInfo to track the current descriptor type as it is updated or copied. Change-Id: I50ab94c29d238517b819933deae0f7272277b431
7 tasks
Track which semaphores are timeline semaphores and write commands to restore their counter values when writing trim state. Change-Id: I3b5f30fa6abd8bc9f3f40561eb03e5b1b14bc50f
Write descriptor state for COMBINED_IMAGE_SAMPLER descriptors if the image is valid and the sampler is immutable. Previously, descriptors with immutable samplers could be excluded from the trim state because they did not have a valid sampler handle. Change-Id: I2b89265fbb6817d37943c613dcd31248e4667500
mikes-lunarg
force-pushed
the
feature-vkd3d-trim-enhancements
branch
from
5e259cb
to
b499ac8
Compare
dustin-lunarg
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add trim support for VK_KHR_timeline_semaphore and VK_VALVE_mutable_descriptor_type as well as miscellaneous bug fixes for trim/replay on vkd3d(proton 5.13)+radv(mesa 21.1)