Fix CaptureManager's shared mutex #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify D3D12CaptuerManager to acquire the excluse API call lock at the entry point of API calls that may activate trimming. These API calls are `IDXGISwapChain::Present` and `IDXGISwapChain1::Present1`. This brings the DX12 lock usage in line with Vulkan's.
Switch `CaptureManager::state_mutex_` from `gfxrecon::util::SharedMutex` to `std::shared_mutex`. `gfxrecon::util::SharedMutex` had known issues and was removed.
Rename `CaptureManager::state_mutex_` to `CaptureManager::api_call_mutex_`--along with the associated locking methods--to better match intended purpose. This mutex is used to block API calls from being executed or processed during trimmed state writing.
davidd-lunarg
requested review from
rurra-amd,
bradgrantham-lunarg and
panos-lunarg
|
CI gfxreconstruct build queued with queue ID 12719. |
|
CI gfxreconstruct build # 2385 running. |
|
CI gfxreconstruct build # 2385 failed. |
|
CI gfxreconstruct build queued with queue ID 12838. |
|
CI gfxreconstruct build # 2386 running. |
|
CI gfxreconstruct build # 2386 failed. |
bradgrantham-lunarg
approved these changes
Feb 7, 2023
rurra-amd
approved these changes
Feb 7, 2023
|
CI gfxreconstruct build queued with queue ID 20979. |
|
CI gfxreconstruct build # 2417 running. |
|
CI gfxreconstruct build # 2417 passed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify DX12/Vulkan
CaptureManagermutex useReplace
CaptureManager'sutil::ShareMutexwithstd::shared_mutexRename
CaptureManager::state_mutex_toapi_call_mutex_