Fixed CreateCreate typos and Regenerated for DX12 #989
Conversation
|
CI gfxreconstruct build queued with queue ID 20069. |
| @@ -40,7 +40,7 @@ | |||
| }, | |||
| "ID3D12Device4": { | |||
| "CreateReservedResource1": "OverrideCreateReservedResource1", | |||
| "CreateCreateCommittedResource1": "OverrideCreateCommittedResource1", | |||
| "CreateCommittedResource1": "OverrideCreateCommittedResource1", | |||
| "CreateCommandList1": "OverrideCreateCommandList1" | |||
There was a problem hiding this comment.
These seem like simple typos. I've addressed them as such.
| auto replay_object = MapObject<ID3D12Device4>(object_id); | ||
| if (replay_object != nullptr) | ||
| auto replay_object = GetObjectInfo(object_id); | ||
| if ((replay_object != nullptr) && (replay_object->object != nullptr)) | ||
| { |
There was a problem hiding this comment.
I'm pretty hazy on how the generated code changed so much as a result. @davidd-lunarg If you get any time, your eyes would be useful on this.
There was a problem hiding this comment.
This looks correct to me. Before this change, the generated code was resolving the objects to their native DX12 types and making the DX12 API call to CreateCommittedResource1/2. After this change, the objects are resolved to GFXR types (e.g., DxObjectInfo) and passed to Dx12ReplayConsumerBase::OverrideCreateCommittedResource1/2 which is responsible for resolving them to the native DX12 types and making the actual DX12 API call to CreateCommittedResource1/2.
|
CI gfxreconstruct build # 2409 running. |
|
CI gfxreconstruct build # 2409 passed. |
andrew-lunarg
force-pushed
the
andy-fix-950-createcreate-duplicates
branch
from
2fdb634
to
fd26ac4
Compare
|
CI gfxreconstruct build queued with queue ID 20495. |
|
CI gfxreconstruct build # 2412 running. |
|
CI gfxreconstruct build # 2412 failed. |
|
CI gfxreconstruct build queued with queue ID 20776. |
|
CI gfxreconstruct build # 2415 running. |
|
CI gfxreconstruct build # 2415 passed. |
andrew-lunarg
force-pushed
the
andy-fix-950-createcreate-duplicates
branch
from
fd26ac4
to
338ec2b
Compare
|
CI gfxreconstruct build queued with queue ID 22671. |
|
CI gfxreconstruct build # 2424 running. |
|
CI gfxreconstruct build # 2424 passed. |
Fixes #950