Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vanilla Material styling for lime-elements #111

Closed
calleboketoft opened this issue Sep 21, 2018 · 2 comments · Fixed by #120
Closed

Use vanilla Material styling for lime-elements #111

calleboketoft opened this issue Sep 21, 2018 · 2 comments · Fixed by #120

Comments

@calleboketoft
Copy link

calleboketoft commented Sep 21, 2018 •
edited by adrianschmidt
Loading

New feature motivation

De-style the UI to use vanilla material design where possible. Benefits:

  • we focus on creating a platform for now, not styling

New feature description

Material UI

New feature implementation

Removing custom styling

Tracked in the feature-waffle by Lundalogik/crm-feature#579
@calleboketoft
Copy link
Author

Hello Adrian, I made the issue with quite few details. We can elaborate more in here if needed.

@CarlitoSweden CarlitoSweden mentioned this issue Sep 24, 2018
Closed
@adrianschmidt adrianschmidt mentioned this issue Sep 27, 2018
Merged
adrianschmidt added a commit that referenced this issue Oct 1, 2018
@adrianschmidt
feat: move towards vanilla material styling
9c1f165 
`material-components-web` has been updated from v0.38.0 to v0.40.0.

BREAKING CHANGE: Visually, there are "breaking" changes. `limel-textfield` has a significantly
different look, which also affects all other components using limel-textfield: `limel-autocomplete`,
`limel-picker`. `limel-select` has received a similar update of visual style. The font has been
changed from Open Sans to Material's default Roboto.

fix #111
adrianschmidt added a commit that referenced this issue Oct 2, 2018
@adrianschmidt
feat: move towards vanilla material styling
bf3a631 
`material-components-web` has been updated from v0.38.0 to v0.40.0.

BREAKING CHANGE: Visually, there are "breaking" changes. `limel-textfield` has a significantly
different look, which also affects all other components using limel-textfield: `limel-autocomplete`,
`limel-picker`. `limel-select` has received a similar update of visual style. The font has been
changed from Open Sans to Material's default Roboto.

fix #111
adrianschmidt added a commit that referenced this issue Oct 2, 2018
@adrianschmidt
feat: move towards vanilla material styling
896ddda 
`material-components-web` has been updated from v0.38.0 to v0.40.0.

BREAKING CHANGE: Visually, there are "breaking" changes. `limel-textfield` has a significantly
different look, which also affects all other components using limel-textfield: `limel-autocomplete`,
`limel-picker`. `limel-select` has received a similar update of visual style. The font has been
changed from Open Sans to Material's default Roboto.

fix #111
adrianschmidt added a commit that referenced this issue Oct 2, 2018
@adrianschmidt
feat: move towards vanilla material styling
d15899a 
`material-components-web` has been updated from v0.38.0 to v0.40.0.

BREAKING CHANGE: Visually, there are "breaking" changes. `limel-textfield` has a significantly
different look, which also affects all other components using limel-textfield: `limel-autocomplete`,
`limel-picker`. `limel-select` has received a similar update of visual style. The font has been
changed from Open Sans to Material's default Roboto.

fix #111
adrianschmidt added a commit that referenced this issue Oct 2, 2018
@adrianschmidt
feat: move towards vanilla material styling
551d398 
`material-components-web` has been updated from v0.38.0 to v0.40.0.

BREAKING CHANGE: Visually, there are "breaking" changes. `limel-textfield` has a significantly
different look, which also affects all other components using limel-textfield: `limel-autocomplete`,
`limel-picker`. `limel-select` has received a similar update of visual style. The font has been
changed from Open Sans to Material's default Roboto.

fix #111
BregenzerK pushed a commit that referenced this issue Oct 3, 2018
@adrianschmidt @BregenzerK
feat: move towards vanilla material styling
a1ed101 
`material-components-web` has been updated from v0.38.0 to v0.40.0.

BREAKING CHANGE: Visually, there are "breaking" changes. `limel-textfield` has a significantly
different look, which also affects all other components using limel-textfield: `limel-autocomplete`,
`limel-picker`. `limel-select` has received a similar update of visual style. The font has been
changed from Open Sans to Material's default Roboto.

fix #111
@ghost ghost removed the review label Oct 3, 2018
limego added a commit that referenced this issue Oct 3, 2018
@limego
chore(release): 6.0.0 [skip ci]
d381939 
# [6.0.0](v5.1.2...v6.0.0) (2018-10-03)

### Bug Fixes

* **limel-select:** set display:block on the custom-element ([0812743](0812743))

### Features

* move towards vanilla material styling ([a1ed101](a1ed101)), closes [#111](#111)

### BREAKING CHANGES

* Visually, there are "breaking" changes. `limel-textfield` has a significantly
different look, which also affects all other components using limel-textfield: `limel-autocomplete`,
`limel-picker`. `limel-select` has received a similar update of visual style. The font has been
changed from Open Sans to Material's default Roboto.
@limego
Copy link
Contributor

limego commented Oct 3, 2018

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this issue Jun 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vanilla material Lundalogik/lime-elements
4 participants
@adrianschmidt @calleboketoft @BregenzerK @limego