Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements #2

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Several improvements #2

merged 1 commit into from
Mar 11, 2019

Conversation

leo60228
Copy link
Contributor

@leo60228 leo60228 commented Mar 3, 2019

  • Run Rustfmt
  • Use Rust 2018 idioms (automatic, via cargo fix)
  • Fix doctests (previously called the wrong methods; decryption on XTSN still doesn't work)
  • Add example for how to decrypt an NCA header

@ThatNerdyPikachu
Copy link

👀

@leo60228
Copy link
Contributor Author

leo60228 commented Mar 4, 2019

@ThatNerdyPikachu if you want something right now, @roblabla already wrote a fully functional NCA parser and decryptor. Check the PRs in MegatonHammer/linkle. I'm not sure, but I think the reason it hasn't been merged might be because of romfs not being supported.

@roblabla
Copy link

roblabla commented Mar 4, 2019

It's not merged because I absolutely hate the code. It's over-generic in all the worst ways. I need to rewrite it using more composable interfaces (notably, I want to switch to using a ReadAt/WriteAt trait instead) but haven't found the time or motivation.

@roblabla
Copy link

roblabla commented Mar 4, 2019

(Also if you need a pure-rust XTS implementation, look at roblabla/block-ciphers@b690b50)

@ThatNerdyPikachu
Copy link

ThatNerdyPikachu commented Mar 5, 2019

@leo60228 Thanks for the suggestion, but I already finished my NCA parser with that library (rob’s XTS) a month ago, lol.

@leo60228
Copy link
Contributor Author

leo60228 commented Mar 5, 2019

@ThatNerdyPikachu Is it public?

@ThatNerdyPikachu
Copy link

@leo60228 not atm.. I’ll put it up on a gist later tho — it do3s use OpenSSL, which id like to change.

@Luro02 Luro02 merged commit 04e09f6 into Luro02:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants