Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve the new implementation of keyboard focus introduced in 3.5.1 #471

Closed
lef-est opened this issue Aug 21, 2024 · 3 comments
Assignees
Labels
bug Something isn't working fixed Fixed in develop or master, to be launched.

Comments

@lef-est
Copy link

lef-est commented Aug 21, 2024

Description

  1. When I click on a word I usually immediately place the cursor in the translation area.
  2. As I'm about to start typing, the keyboard focus went to the reading pane.
  3. Unaware of the loss of focus, or driven by muscle memory, I still start to type, accidentally triggering some keyboard shortcut, which usually ends in refreshing the whole page.

Problem
Keyboard focus should remain in the translation area if the cursor is already there.

@jzohrab
Copy link
Collaborator

jzohrab commented Aug 21, 2024

Thank you, I think I have to remove that focus work, it had some good sides but also some bad as you're finding. Thanks for the issue.

@jzohrab jzohrab self-assigned this Aug 21, 2024
@jzohrab jzohrab added the bug Something isn't working label Aug 21, 2024
@jzohrab
Copy link
Collaborator

jzohrab commented Aug 24, 2024

I've backed out #459 in the develop branch, so this fix will be launched with 3.5.2, which will likely be out soon-ish. Thanks again @lef-est 👋

@jzohrab jzohrab added the fixed Fixed in develop or master, to be launched. label Aug 24, 2024
jzohrab added a commit that referenced this issue Aug 24, 2024
…b-autofocus"

PR 459 tried to address the dictionary fram pulling focus, but that PR
caused other issues:

- term form losing focus early - #471
- some dictionaries not loading - #469

This reverts commit 397211c, reversing
changes made to 1284c25.
@jzohrab
Copy link
Collaborator

jzohrab commented Aug 27, 2024

Launched in 3.5.2, should be fixed now.

@jzohrab jzohrab closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Fixed in develop or master, to be launched.
Projects
Archived in project
Development

No branches or pull requests

2 participants