Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Testing + Deprecate Nonsensical Functions + Better Naming for Kwargs #80

Merged
merged 9 commits into from
Jul 7, 2022

Conversation

avik-pal
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #80 (dcb7f6d) into main (94fe305) will increase coverage by 11.26%.
The diff coverage is 90.42%.

@@             Coverage Diff             @@
##             main      #80       +/-   ##
===========================================
+ Coverage   59.91%   71.18%   +11.26%     
===========================================
  Files          14       14               
  Lines         953      989       +36     
===========================================
+ Hits          571      704      +133     
+ Misses        382      285       -97     
Impacted Files Coverage Δ
src/Lux.jl 100.00% <ø> (ø)
src/adapt.jl 62.50% <0.00%> (+25.00%) ⬆️
src/autodiff.jl 56.52% <ø> (+4.52%) ⬆️
src/layers/basic.jl 60.00% <ø> (-0.63%) ⬇️
src/transform.jl 0.00% <0.00%> (ø)
src/nnlib.jl 63.06% <33.33%> (ø)
src/layers/normalize.jl 51.28% <76.47%> (+17.63%) ⬆️
src/core.jl 100.00% <100.00%> (+18.60%) ⬆️
src/deprecated.jl 100.00% <100.00%> (+100.00%) ⬆️
src/layers/conv.jl 100.00% <100.00%> (+52.88%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94fe305...dcb7f6d. Read the comment docs.

@avik-pal avik-pal force-pushed the ap/tests branch 4 times, most recently from a28df5e to 0138619 Compare June 29, 2022 05:56
@avik-pal avik-pal force-pushed the ap/tests branch 9 times, most recently from efe5713 to 3c7b9d7 Compare June 30, 2022 04:48
@avik-pal avik-pal changed the title More testing More Testing + Deprecate Non-sensical Functions + Better Naming for Kwargs Jul 1, 2022
@avik-pal avik-pal force-pushed the ap/tests branch 3 times, most recently from 6a11726 to e6a9c5d Compare July 1, 2022 05:15
@avik-pal avik-pal changed the title More Testing + Deprecate Non-sensical Functions + Better Naming for Kwargs More Testing + Deprecate Nonsensical Functions + Better Naming for Kwargs Jul 1, 2022
@avik-pal
Copy link
Member Author

avik-pal commented Jul 7, 2022

This PR is not complete, but I am going to merge it because v0.4.7 broke certain functionality

@avik-pal avik-pal merged commit d620d82 into main Jul 7, 2022
@avik-pal avik-pal deleted the ap/tests branch July 7, 2022 06:26
avik-pal pushed a commit that referenced this pull request Nov 3, 2024
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.9 to 1.23.1.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.22.9...v1.23.1)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant