added new Activity Type: system commands

[skobkars]

New Activity Type: System Commands

Sends commands line by line to your Pi (or other host) and stops processing in case of an error.

Outputs of all commands are logged in octoprint.log

[LuxuSam]

Nice thank you very much! On first glance it looks well coded and also fits my coding style. I will look at it more thoroughly tomorrow :)

[LuxuSam]

The PR looks good, just one question. Why did you add GPIO 2 & 3? As far as I can see, those have preconfigured pull-up resistors. Won't that be a problem when applying that again on my button setup function or won't that make a difference?

[skobkars]

Hi Sam, Applying pull-ups on ## 2,3 is harmless and it works just fine. I have added them (especially #3) for a very simple reason actually: as #3 is used to wake-up/start RPi after shutting down, connecting a single button to it allows it to be used for both shutting down and starting up processes for example. In fact, in my case I only have one button to start with, so it is used for toggling LED lights when the printer is up, for turning printer on (Octopi is running) if it was down, and for starting up the whole setup (Printer + Octopi) if the Octopi was down. Very convenient. Regards, Sergey

…

On Thu, Aug 5, 2021 at 10:39 AM Sam Mattiussi ***@***.***> wrote: The PR looks good, just one question. Why did you add GPIO 2 & 3? As far as I can see, those have preconfigured pull-up resistors. Won't that be a problem when applying that again on my button setup function or won't that make a difference? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACLEOOKRCAFGEVCSIW7EGWTT3LEFLANCNFSM5BQKFLNA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[LuxuSam]

Cool thanks for clearing that up :)

I'll probably release your changes during the weekend :)

[skobkars]

Awesome! Glad you find it useful.

…

On Fri, Aug 6, 2021 at 9:07 AM Sam Mattiussi ***@***.***> wrote: Cool thanks for clearing that up :) I'll probably release your changes in the weekend :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACLEOOLHRV42S7GGEE7BNJLT3QCD7ANCNFSM5BQKFLNA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .