Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute_statistics methode and save_statistics methode #33

Closed
riberaborrell opened this issue Mar 13, 2020 · 5 comments
Closed

compute_statistics methode and save_statistics methode #33

riberaborrell opened this issue Mar 13, 2020 · 5 comments
Assignees

Comments

@riberaborrell
Copy link
Collaborator

No description provided.

@riberaborrell
Copy link
Collaborator Author

riberaborrell commented Apr 15, 2020

save_statistics() method should have just one input variable: npz_path.

@LuzieH
Copy link
Owner

LuzieH commented Apr 16, 2020

@eborrell maybe the save statistics method should raise an error if some of the statistics haven't yet been computed? (when they are still None)
or we keep it as it is, then these not computed statistics are just None, which might be good, because maybe one is not always interested in saving everything

@riberaborrell
Copy link
Collaborator Author

by Luzie: @eborrell I think now that i changed the folder structure there is some problem with the paths in the save_statistics method.
In the transition_paths code it should use DATA_PATH =...examples/data instead of DATA_PATH = ...src/transitions/data, e.g. the method could be changed such that the path has to be inputted to the save_statistics method?

@riberaborrell
Copy link
Collaborator Author

@LuzieH I would rather leave it like it is. Then the save_statistics() method works always independent of what you have computed. It just saves the actual status of your statistics.

@LuzieH
Copy link
Owner

LuzieH commented Apr 17, 2020

@LuzieH I would rather leave it like it is. Then the save_statistics() method works always independent of what you have computed. It just saves the actual status of your statistics.

ok 👍 I agree, that's the best way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants