Use OCI Label defaults on Docker images

[hypery2k]

According to OCI these labels should be applied: https://github.com/opencontainers/image-spec/blob/main/annotations.md

I didn't found the docker image build, maybe you're using docker hub build. Idea would be to pass BUILD_DATE and APP_VERSION as build arguments

[Luzifer]

Hmm I don't really get the intention behind this change. Please explain the benefit of having those tags set. Is there anything out there using those labels or are they just present for the sake of being present? (Haven't seen anything - including myself - using them out there…)

Regarding those two args: They will be always empty. The build system does not know anything about the contents of the container and will not know anything about it (auto-generated generic build system used for dozens of images).

Aside of this: There is a missing = in the version label.

[hypery2k]

you're right. I fixed the typo

The benefit is, that these labels are standardized and can be crawled by tools like artifacthub and snyk.io: https://snyk.io/de/blog/how-and-when-to-use-docker-labels-oci-container-annotations/

[hypery2k]

BTW: I deployed a simple OTS Helm chart: https://artifacthub.io/packages/helm/ots/ots

[Luzifer]

Hmm still not sure about the ARGs… …I can agree on the static values. I could agree on a version set through patch on release (so the tag will always have the correct version, latest will "lie" about the version until the next release)… But setting them as ARGs will just lead to empty labels which are useless.

So what do you think?

• Removing the build-time, setting version through on-release patcher
• Removing build-time and version
• Keeping it the way it was before this PR

[hypery2k]

I agree with you, that empty values would be useless.

Regarding the version: Are you using docker auto build? I think you can set build args there. So would prefer option 1