-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security HTTP headers #45
Conversation
d4e6922
to
ab0bb9b
Compare
Please rebase onto master and resolve conflicts
ab0bb9b
to
f46c901
Compare
It was a missing Content-Type header. Also changed the template a bit. Should have noticed this while I was checking #47, sorry! |
Should I add |
871cd1c
to
230a1df
Compare
I think adding Depending on which headers you are adding in the proxy your users might experience this too… |
230a1df
to
86ec81b
Compare
Agree. I'll keep them in my nginx config. |
Sadly, the Vue web interface needs unsafe-inline for both stylesheets and scripts, making the CSP header a bit useless.
Serving the page without Content-Type seems to work but confuses the view-source mode in Firefox.
Parsing the template for every request makes no sense.
We have only a single variable left, better to remove the map/loop for now.
86ec81b
to
fdd9eb6
Compare
Sadly, the Vue web interface needs unsafe-inline for both stylesheets and scripts, making the CSP header a bit useless.
Browsers tend to implement CSP a bit different, so this should be tested in a few browsers. The code changed in this PR is currently live on https://ots.webserve.be and works in Firefox and Chrome.