Added optional flag to disable exception on dependency check fail #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Adding optional parameter to the ctor is not backward compatible change. Consider to add separate constructor with throwExceptionOnFail flag. This will allow to use old code, which is referenced to the old version of the SettingsReader with new SettingReader version actually referenced by the entry-point assembly.
samodovdi
approved these changes
Feb 12, 2018
| @@ -4,9 +4,19 @@ namespace Lykke.SettingsReader.Attributes | |||
| { | |||
| public class AmqpCheckAttribute : BaseCheckAttribute | |||
There was a problem hiding this comment.
Plz add a description. It is a public shared class with an unclear name.
MikhailGerasimov
approved these changes
Feb 12, 2018
| } | ||
|
|
||
| var checkResult = checker.CheckField(model, property.Name, val); | ||
| Console.WriteLine(checkResult.Description); | ||
| if (!checkResult.Result && checkResult.ThrowExceptionOnFail) |
There was a problem hiding this comment.
Will be better to incapsulate this check and exception throwing into the FieldCheckResult.ThrowIfFailed() method or something like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.