Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Consider extracting web/js/jbrowse/plugins/CoGe into a separate repo #75

Closed
vivekkrish opened this issue May 4, 2017 · 7 comments

Comments

@vivekkrish
Copy link

vivekkrish commented May 4, 2017

Hello @LyonsLab CoGe JBrowse maintainers,

Just a thought, would you consider decoupling the jbrowse/plugins/CoGe directory from the main coge repo into its own standalone repository, so that, anyone who wishes to use your CoGe/View/Track/Wiggle/XYPlot track type (or other neat extensions) can easily clone the repo into their own JBrowse forks?

Thank you for your consideration.

@sdavey
Copy link
Member

sdavey commented May 5, 2017 via email

@vivekkrish
Copy link
Author

Thank you for your consideration, @sdavey!

Just as an FYI, in the past, we've used this method to split out a particular subdirectory into its own repo. Following this, we removed it from the main repo and added it back as a git submodule.

@sdavey
Copy link
Member

sdavey commented May 5, 2017 via email

@sdavey
Copy link
Member

sdavey commented May 15, 2017 via email

@vivekkrish
Copy link
Author

vivekkrish commented May 16, 2017

Thank you very much, @sdavey. This is perfect!

I would recommend adding a README.md to the new repo, with some instructions on how to install the plugin and use in JBrowse. You could also update the JBrowse registry entry for the CoGe plugin.

BTW, I've created a PR to your plugin repo (LyonsLab/CoGe_plugin#1) which addresses some issues with code minifying. Please review and accept changes at your convenience. Thanks!

@vivekkrish
Copy link
Author

Just an FYI, might want to update your documentation here (https://genomevolution.org/wiki/index.php/Install_coge#Deploy_the_Web_Site) to run a git clone --recursive in order to pull down the CoGe JBrowse Plugin submodule.

@sdavey
Copy link
Member

sdavey commented May 16, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants