Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin system #8

Merged
merged 6 commits into from
Nov 16, 2018
Merged

Plugin system #8

merged 6 commits into from
Nov 16, 2018

Conversation

7twin
Copy link
Contributor

@7twin 7twin commented Nov 16, 2018

  • added plugin autoloader (loaded from CALLBACK_CLASSES config array)
  • plugin interface (which plugins must implement from)
  • implemented class method checks
  • new defined configuration keys (CALLBACK_CLASSES, PLUGINS_FOLDER)
  • plugin error handling (non-breaking because a webhook not firing should not fatal throw and be silently logged)
  • added more success webhook callback keys
  • added the discord plugin as a default example of a working plugin implementation
  • fixed an issue with the recent change to endScript() where it would display the same message after errorPage()

More discussion and changes described here: #6

7twin added 6 commits November 8, 2018 20:01
- added plugin autoloader
- plugin interface (which plugins must implement from)
- implemented class method checks
- new defined configuration key
- plugin error handling (non-breaking because a webhook not firing should not fatal throw and be silently logged)
- added more success callback keys
- added the discord plugin as a default example
- fixed an issue with the recent change to `endScript()` where it would display the same message after `errorPage()`
@rubenreyes2000 rubenreyes2000 merged commit 0965533 into Lyquix:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants