Skip to content

Commit a10126f

Browse files
committed
Fix range status comparison
1 parent b432c90 commit a10126f

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

components/roode/roode.cpp

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -90,21 +90,20 @@ namespace esphome
9090

9191
bool Roode::handleSensorStatus()
9292
{
93-
static const char *statusString = VL53L1X::rangeStatusToString(sensor_status); // This function call will manipulate the range_status variable
93+
const char *statusString = VL53L1X::rangeStatusToString(sensor_status); // This function call will manipulate the range_status variable
9494
ESP_LOGD(TAG, "Sensor status: %d, Last sensor status: %d", sensor_status, last_sensor_status);
9595

96-
if (last_sensor_status == sensor_status && sensor_status == VL53L1X::RangeStatus::RangeValid)
96+
if (last_sensor_status == sensor_status && sensor_status == 0)
9797
{
9898
if (status_sensor != nullptr)
9999
{
100100
status_sensor->publish_state(statusString);
101101
}
102102
return true;
103103
}
104-
if (sensor_status != VL53L1X::RangeStatus::RangeValid && sensor_status != VL53L1X::RangeStatus::SignalFail && sensor_status != VL53L1X::RangeStatus::WrapTargetFail)
104+
if (sensor_status != 0 && sensor_status != 2 && sensor_status != 7)
105105
{
106106
ESP_LOGE(TAG, "Ranging failed with an error. status: %d, error: %s", sensor_status, statusString);
107-
108107
return false;
109108
}
110109
return true;
@@ -126,10 +125,10 @@ namespace esphome
126125
distance = distanceSensor.read();
127126
distanceSensor.writeReg(distanceSensor.SYSTEM__MODE_START, 0x80); // stop reading
128127
sensor_status = distanceSensor.ranging_data.range_status;
129-
// if (!handleSensorStatus())
130-
// {
131-
// return;
132-
// }
128+
if (!handleSensorStatus())
129+
{
130+
return;
131+
}
133132

134133
if (use_sampling_)
135134
{

0 commit comments

Comments
 (0)