Refactor people counter to a number component

[CarsonF]

This replaces the sensor for people counts with a number. Numbers are controllable which makes it much easier to change the state in HA UI & automation without having to create lambda API services.

This number is configured for people counting so min=0, step=1, max is configurable.

It is an instance of a new PersistedNumber object I created, that saves/restores the value using a native esphome API. This removes our explicit EEPROM dependency.

This flash write is debounced and can be user configured, defaults to once a minute.
https://esphome.io/components/esphome.html#adjusting-flash-writes
In testing it seems pending writes are still saved on graceful reboot.
Note that ESP8266 have this disabled by default, so...

esp8266:
  restore_from_flash: true

Since this count was the only value that was persisted/"restored", I removed the restore_values config option in favor of restore_value on the number component.

I couldn't figure out how to reference the roode platform outside of its platform setup, so for now it's just there. I suspect I just missed something and it can be moved to an independent number entry with the roode platform.

number:
  - platform: roode
    people_counter:
      name: $friendly_name people counter
      max_value: 5 # default 10

[Lyr3x]

Good job! Thanks a lot for that awesome refactor!
I added some minor request changes though, nothing big.
To use a proper number entity in the esphome config, you should carve out the number component analog to text_sensor etc. That way you can define the number like this:

number:
  - platform: roode
    people_counter:
      name: $friendly_name people counter
      restore_value: true

This should work:
number.py:

import esphome.codegen as cg
import esphome.config_validation as cv
from esphome.components import number
from typing import OrderedDict
from esphome.const import (
    CONF_ID,
    CONF_ICON,
    CONF_ACCURACY_DECIMALS,
    CONF_MAX_VALUE,
    CONF_RESTORE_VALUE,
)
from . import Roode, CONF_ROODE_ID

roode_ns = cg.esphome_ns.namespace("roode")
PersistedNumber = roode_ns.class_("PersistedNumber", number.Number, cg.Component)

DEPENDENCIES = ["roode"]
CONF_PEOPLE_COUNTER = "people_counter"
TYPES = [CONF_PEOPLE_COUNTER]

CONFIG_SCHEMA = cv.Schema(
    {
        cv.GenerateID(CONF_ROODE_ID): cv.use_id(Roode),
        cv.Optional(CONF_PEOPLE_COUNTER): number.NUMBER_SCHEMA.extend(
            {
                cv.GenerateID(): cv.declare_id(PersistedNumber),
                cv.Optional(CONF_ICON, default="mdi:counter"): cv.icon,
                cv.Optional(CONF_MAX_VALUE, 10): cv.int_range(1, 255),
                cv.Optional(CONF_RESTORE_VALUE): cv.boolean,
            }
        ),
    }
)


async def people_counter(config: OrderedDict):
    """People counter, which is a persisted number, but min/max/step are specific to people counts"""
    var = cg.new_Pvariable(config[CONF_ID])
    await cg.register_component(var, config)
    await number.register_number(
        var, config, min_value=0, max_value=config[CONF_MAX_VALUE], step=1
    )
    if CONF_RESTORE_VALUE in config:
        cg.add(var.set_restore_value(config[CONF_RESTORE_VALUE]))
    return var

async def to_code(config):
    hub = await cg.get_variable(config[CONF_ROODE_ID])
    if CONF_PEOPLE_COUNTER in config:
        counter = await people_counter(config[CONF_PEOPLE_COUNTER])
        cg.add(hub.set_people_counter(counter))

Then you can remove the whole people counter from __init__.py

[Lyr3x]

Suggested change

	this->publish_state(newValue);
	ESP_LOGI("People Counter", "Updating people counter to: %d", (int)newValue);
	this->publish_state(newValue);

[CarsonF]

Parent has one so I omitted because I didn't want to duplicate
https://github.com/esphome/esphome/blob/b5a0e8b2c0d016ea384f4f962e0f0e4c61a8dc85/esphome/components/number/number.cpp#L36

It's debug level, but I think logs are only relevant at the debug level anyways. Otherwise you just can observe the current state.

I'll add it though if you really want an info level as well.

[Lyr3x]

Yes because the parent has its on DEBUG i have this added previously as INFO because i need this log very often when testing things and only check the terminal. I dont use HA when developing stuff. That's a essential log line.

When setting the level to DEBUG there is a lot going one which i only do if i really want to see step by step whats going on.

[CarsonF]

K LMK what you think of new code. Since it has nothing to do with roode or people counting now I left it as a float.

[CarsonF]

Then you can remove the whole people counter from __init__.py

Yeah I tried all of that yesterday with a number file—I couldn't access roode config. I think I was missing this line to make it work:

 cv.GenerateID(CONF_ROODE_ID): cv.use_id(Roode),

I also wanted to move persisted number python code to a separate persisted_number.py but I think esphome tried to load it because of MULTI_CONF so I gave up and merged it back into the file.

[Lyr3x]

In ESPHome sense it is a number so just put it to the number.py like above and we are good to go 👍