Fix sensor init #97
Closed
Fix sensor init #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarsonF
reviewed
Jan 17, 2022
There was a problem hiding this comment.
I'm not convinced all this init code needs to be reverted. This also does not count for the address bit shifting the ULD library does.
Besides that the only thing I really see here that's different is the wait_for_boot() before address set and 100ms delay after address set.
The wait for boot before the address change seemed not necessary and it seem needed on my chips. If you are having problems I'd like to try just adding those two lines and see if it gets resolved.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.