Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generically's Monoid instance uses wrapped type's (<>) #18

Merged
merged 1 commit into from
May 3, 2019

Conversation

yairchu
Copy link
Contributor

@yairchu yairchu commented May 1, 2019

PR for #17

Note that Generically now does not have a Monoid instance unless it wraps something with a Semigroup instance, so had to add an instance derivation in the test too.

@Lysxia
Copy link
Owner

Lysxia commented May 3, 2019

Ah yes, DerivingVia should be hidden behind a CPP block for older GHCs. (Maybe it would be a good idea in the future to split tests relying on post-8.6 in separate files...)

@yairchu
Copy link
Contributor Author

yairchu commented May 3, 2019

Oh! So instead of that I've made the instance with a bit of boiler-plate so it will also work pre 8.6.

@Lysxia Lysxia merged commit 43ba0dd into Lysxia:master May 3, 2019
@Lysxia
Copy link
Owner

Lysxia commented May 3, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants