Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing of M3U8ExtXKey #17

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Add parsing of M3U8ExtXKey #17

merged 4 commits into from
Feb 12, 2019

Conversation

PierrePerrin
Copy link
Contributor

Hi,

I've add the ability to parse the M3U8ExtXKey.
This could be useful for parsing content identifier for protected content such as FairPlay or HLS-AES content.

Thank you.

@wolfcon
Copy link
Member

wolfcon commented Jan 10, 2019

Add a m3u8 file example (just like 769.m3u8 in demo project) for demo to test it plz.

PS: thx for PR. rebase your code and collect it

@PierrePerrin
Copy link
Contributor Author

Hi, I've just added an example of encrypted file into the demo project directory.

@wolfcon
Copy link
Member

wolfcon commented Jan 11, 2019

My man. More detail should be concerned with multi-key.

See this:

#EXTM3U
#EXT-X-VERSION:3
#EXT-X-MEDIA-SEQUENCE:7794
#EXT-X-TARGETDURATION:15
 
#EXT-X-KEY:METHOD=AES-128,URI="https://priv.example.com/key.php?r=52"
 
#EXTINF:2.833,
http://media.example.com/fileSequence52-A.ts
#EXTINF:15.0,
http://media.example.com/fileSequence52-B.ts
#EXTINF:13.333,
http://media.example.com/fileSequence52-C.ts
 
#EXT-X-KEY:METHOD=AES-128,URI="https://priv.example.com/key.php?r=53"
 
#EXTINF:15.0,
http://media.example.com/fileSequence53-A.ts

There is a circumstance that has more than one key in M3U8 file.

@interface M3U8MediaPlaylist : NSObject

@property (readonly, nonatomic, strong) M3U8ExtXKey *key;

The property should not be handled like this. 😎

Copy link
Member

@wolfcon wolfcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#EXT-X-KEY May be more than one

@PierrePerrin
Copy link
Contributor Author

Hi,

I've removed the parsing of the M3U8ExtXKey and added M3U8ExtXSessionKey parsing directly in the master playlist.

Thanks

@wolfcon
Copy link
Member

wolfcon commented Feb 3, 2019

Thx for your contribution.🎉
I will merge these and modify some other things once I come back from vacation.

@wolfcon wolfcon closed this Feb 12, 2019
@wolfcon
Copy link
Member

wolfcon commented Feb 12, 2019

already solved thx man

@wolfcon wolfcon reopened this Feb 12, 2019
@wolfcon wolfcon merged commit 69f6f2e into M3U8Kit:master Feb 12, 2019
@wolfcon
Copy link
Member

wolfcon commented Mar 6, 2019

@PierrePerrin hello. I've refactored X-Key & X-SessionKey function.
X-Key & X-SessionKey are both supported by M3U8Kit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants