Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/112: Enable environment variables #114

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

frankinspace
Copy link
Contributor

@frankinspace frankinspace commented May 8, 2024

Closes #112

Adds ability to load settings from environment variables.

Uses same default value if environment variable does not exists.
Parses value to appropriate datatype from string.

Copy link
Collaborator

@bsatoriu bsatoriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankinspace frankinspace changed the base branch from main to develop May 8, 2024 23:34
Copy link
Contributor

@grallewellyn grallewellyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@frankinspace frankinspace merged commit 1d23293 into develop May 15, 2024
1 check passed
@frankinspace frankinspace deleted the issues/112 branch May 15, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use environment variables in settings.py file
3 participants