Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slug on model class Facility is not unique #96

Closed
cspanring opened this issue Jun 13, 2012 · 4 comments
Closed

Slug on model class Facility is not unique #96

cspanring opened this issue Jun 13, 2012 · 4 comments
Assignees
Labels

Comments

@cspanring
Copy link
Contributor

Does it need to be unique?

@ghost ghost assigned marilynfletcher Jun 13, 2012
@tyrelsouza
Copy link
Contributor

I have made it unique now in the models.py file. It would make sense for it to be unique, as a slug is a lot easier on the eyes than someone seeing numbers all over the place and questioning what is being referred.

@tyrelsouza
Copy link
Contributor

Although I'm not sure we even need a slug on Facility, I just checked and it isn't used ANYWHERE in the code. I will do some testing to see what commenting this out affects.

@cspanring
Copy link
Contributor Author

That's what I thought. There is no facility page where a slug would be useful. We might as well drop it. Just wanted to confirm.

-----Original Message-----
From: Tyrel Souza [mailto:reply@reply.github.com]
Sent: Wednesday, June 13, 2012 10:46 AM
To: Christian Spanring
Subject: Re: [bostonparks] Slug on model class Facility is not unique (#96)

Although I'm not sure we even need a slug on Facility, I just checked and it isn't used ANYWHERE in the code. I will do some testing to see what commenting this out affects.


Reply to this email directly or view it on GitHub:
#96 (comment)

Please be advised that the Massachusetts Secretary of State considers e-mail to be a public record, and therefore subject to the Massachusetts Public Records Law, M.G.L. c. 66 § 10.

@tyrelsouza
Copy link
Contributor

Yeah, it's commented out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants