Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix META.info #9

Merged
merged 1 commit into from
Aug 5, 2015
Merged

Fix META.info #9

merged 1 commit into from
Aug 5, 2015

Conversation

jonathanstowe
Copy link
Contributor

Hi,
This should fix your Raku/ecosystem#51 - the META.info wasn't valid JSON.

MARTIMM added a commit that referenced this pull request Aug 5, 2015
@MARTIMM MARTIMM merged commit 55477bd into MARTIMM:master Aug 5, 2015
@MARTIMM
Copy link
Owner

MARTIMM commented Aug 6, 2015

Hi Jonathan, I'm staring at the merge conflict now. If I remove the old part then I would have less modules in the 'provides' list. Also I can't see what is wrong with the JSON? Can you help me out?
Thanks

@jonathanstowe
Copy link
Contributor Author

Hi,
The line in the provides with " "BSON::Exception": "lib/BSON/Exception.pm6"" was missing a comma at the end, and the last line of the "provides" has an extra comma, strict JSON doesn't allow a comma at the end of a list like that even though some parsers may allow it (the JSON::Tiny doesn't)

I tend to feed META.info through a command line json validator before shipping it.

@MARTIMM
Copy link
Owner

MARTIMM commented Aug 6, 2015

Thank you for explanation. I must have sorted the lines without checking further.

@jonathanstowe
Copy link
Contributor Author

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants