Gh 613 since first review #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 31, 2022 20:35
…ity is nicely refactored now
… do some last refactoring before the review 2
bertllll
added a commit
that referenced
this pull request
Sep 3, 2022
…untant...version 2 with a fix (#167) * GH-613: half of messages to accrue debts handled * GH-613: preparing tests for handling reports to acountant regarding the return route * GH-613: continuing building structures for agreggated reporting; now at the response side...finalizing tests that will cover this change * GH-613: before trying to appeace tests with meaningless expected services * GH-613: old tests in proxy server passing; two todos left * GH-497: Accountant one more test fixed * GH-613: last tests in accountant were caressed and now sleep well * GH-613: last todos knocked out * GH-613: autoreview * GH-613: Revamped msg_id() * GH-613: wrote a test that could detect the wrong timestamp...and much more than just timestamp * GH-613: one version to fix it, will test alternatives * GH-613: slightly lighter version * GH-613: interim commit...I need to undress recorder and instead get it the assert message * GH-613: the lack of tests is gone * GH-613: ready for Actions * GH-613: save point before an experiment * GH-613-since-first-review: blind alley; though the coflict of mutability is nicely refactored now * GH-613-since-first-review: it works and looks prettier, let's go to have a party time * GH-613-since-first-review: finished refactoring of handle_IBCD * GH-613-since-first-review: fixed a couple of tests * GH-613-since-first-review: knocked out a few more requests from the review * GH-613-since-first-review: a few more features fixed; msg id generator edhancemend * GH-613-since-first-review: everything requested is fixed; now I might do some last refactoring before the review 2 * GH-613-since-first-review: finished, now review? * Gh 613 since first review (#168) * GH-613: save point before an experiment * GH-613-since-first-review: blind alley; though the coflict of mutability is nicely refactored now * GH-613-since-first-review: it works and looks prettier, let's go to have a party time * GH-613-since-first-review: finished refactoring of handle_IBCD * GH-613-since-first-review: fixed a couple of tests * GH-613-since-first-review: knocked out a few more requests from the review * GH-613-since-first-review: a few more features fixed; msg id generator edhancemend * GH-613-since-first-review: everything requested is fixed; now I might do some last refactoring before the review 2 * GH-613-since-first-review: finished, now review? Co-authored-by: Bert <Bert@Bert.com> * GH-613-second-review: repaired tests in proxy_server/mod.rs which were sensitive on is_decentralized * GH-613-second-review: some minor changes, sweeping; should be done all * GH-613-second-review: changed versioning of crates round the codebase Co-authored-by: Bert <Bert@Bert.com> Co-authored-by: Dan Wiebe <dnwiebe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.