GH-647: Review 1 #214
Merged
GH-647: Review 1 #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwiebe
reviewed
Dec 29, 2022
node/src/neighborhood/mod.rs
Outdated
| @@ -5513,7 +5518,7 @@ mod tests { | |||
| database: &mut NeighborhoodDatabase, | |||
| agrs: Vec<AccessibleGossipRecord>, | |||
| gossip_source: SocketAddr, | |||
| _peer_addrs: &[IpAddr], | |||
| _connection_progress_peers: &[IpAddr], | |||
There was a problem hiding this comment.
This field shouldn't be ignored by the mock, and whatever tests assert on these parameters should also assert on this one.
utkarshg6
added a commit
that referenced
this pull request
Dec 31, 2022
…#213) * GH-647: make the ip addresses of initial node descriptors as part of previous pass targets * GH-647: test drive the case where the pass target is a duplicate of peer address present in a different connection progress * GH-647: remove the commented test in overall_connection_status.rs * Revert "GH-647: make the ip addresses of initial node descriptors as part of previous pass targets" This reverts commit afd43da. * GH-647: pass the vector of peer_addrs to the handle() of GossipAcceptor and GossipHandler * GH-647: test drive the function to get current peer addrs * GH-647: add test in neighborhood that the gossip is being ignored * GH-647: remove the warnings * GH-647: remove clippy warnings * GH-647: remove clippy warnings * GH-647: Review 1 (#214) * GH-647: rename peers_addrs to connection_progress_peers * GH-647: provide the accurate name inside the constructor of System in the test * GH-647: reword the trace logs for the unnecessary connection progress * GH-647: use a unique number to generate a unique socket address for peer 2 * GH-647: add review changes for overall_connection_status.rs * GH-647: add connection_progress_peers as a param in the mock (#216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.