Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-449: Removal of BroadcastTrigger #26

Merged
merged 42 commits into from
Aug 20, 2021
Merged

GH-449: Removal of BroadcastTrigger #26

merged 42 commits into from
Aug 20, 2021

Conversation

bertllll
Copy link
Contributor

No description provided.

@bertllll
GH-244: migration tools seem roughly prepared
972ef7f
@bertllll
GH-244: migrator looks as a good officer now
8ad8ea1
@bertllll
GH-244: clean-up that was needed
6474e6d
@bertllll
GH-244: database migrations should work since now; next some code per…
176082e 
…iferies
@bertllll
GH-244: completed except a broadcast message
66648b7
@bertllll
Merge branch 'master' into GH-244
c61455d
@bertllll
GH-244: clean-up
1284092
@bertllll
GH-244: changing panic for an error message
d9a41b9
@bertllll
GH-244: eliminating a race condition in masq
7c1f6a9
@bertllll
GH-244: adjusting an older test in interactive_mode.rs again
d7fd976
@bertllll
GH-244: little enhancement in various places
74739e2
@bertllll
GH-244: my own review
5d7aec2
@bertllll
GH-244: removing debugging and expect_value modified a bit
2b09c95
@bertllll
GH-244: first review resolved except the right method of mocking
1bc28fe
@bertllll
GH-244: save point before an attempt with generics
8ed3a96
@bertllll
GH-244: this finally seems that it's gonna work well
4a5c0dc
@bertllll
GH-244: becoming fairly robust
8a4f507
@bertllll
GH-244: a few more tests
9fa8ec6
@bertllll
GH-244: DbMigrator is complete; now let's make last changes to db_ini…
3924604 
…tializer.rs
@bertllll
GH-244: this commit ends the first common review
405cbb2
@bertllll
GH-244: clippy + automatic removing a former database file in an inte…
6cdcc52 
…gration test
@bertllll
GH-244: seems like they updated Clippy mid-flight; fix for MWSS
a73c293
@bertllll
GH-244: formatting
62b122c
@bertllll
GH-244: another nihil-like correction
49bf139
@bertllll
GH-244: grr, until now clippy wasn't muted in all cases
56e3934
@bertllll
GH-244: after 2/3 of the second review
bcd877d
@bertllll
GH-244: daemon - prolonging the delay for response from the UI
ac66079
@bertllll
GH-449: brutto ok, just some rearrangement in a few tests may wait fo…
06d2141 
…r me
@bertllll
GH-244: another partial response to the second review
1aca215
@bertllll
GH-244: after some new comments within the third review
f331d04
bertllll
bertllll commented Jul 22, 2021
View reviewed changes
masq_lib/src/test_utils/mock_websockets_server.rs Outdated Show resolved Hide resolved
masq_lib/src/test_utils/mock_websockets_server.rs Outdated Show resolved Hide resolved
masq_lib/src/test_utils/mock_websockets_server.rs Show resolved Hide resolved
node/src/database/db_initializer.rs Outdated
obtained_s_v
)
})
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examine why this code returns under the lights, did I make a mistake in the master merge?

@dnwiebe dnwiebe merged commit b2bd432 into master Aug 20, 2021
@dnwiebe dnwiebe deleted the GH-449 branch August 20, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnwiebe dnwiebe dnwiebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertllll @dnwiebe