Gh-478: Addition of config values written to database + updating db initialization and migration + better tooling in ntegration tests for Node #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ny days - and plus formatting
… choosen in configurator_standard
…onfiguration' command
…ndand and is gone
…ith tools for dump config in integration tests are not flexible enough
… integration tests from GH-305
…ing happened; grrr
…ockchain_service_url; some small changes for BlockchainBridgeClandastine and verify_bill_payments()
masqrauder
reviewed
Nov 27, 2021
| let (serving_node_2_config, serving_node_2_wallet) = | ||
| build_config(&blockchain_server, &seed, derivation_path(0, 2)); | ||
| let (serving_node_3_config, serving_node_3_wallet) = | ||
| build_config(&blockchain_server, &seed, derivation_path(0, 3)); | ||
|
|
||
| let amount = 10u64 | ||
| * u64::try_from(node_lib::accountant::PAYMENT_CURVES.permanent_debt_allowed_gwub).unwrap(); |
There was a problem hiding this comment.
gwub is actually short for $SUB in Gwei so if you felt so inclined to change it to gwei or qwaq or something else that would be fine. Or you could leave it too... that's fine. It's one of those 'you had to be there to know' kind of things.
There was a problem hiding this comment.
I think we will likely change the naming of this sometime soon - we are looking to change the naming of the payment curve values anyways, since they are very confusing!
There was a problem hiding this comment.
I'm going to take care of the nomenclature in a different card because I've started that in there and I want to do it just at one place.
masqrauder
reviewed
Nov 27, 2021
node/src/lib.rs
Outdated
| @@ -4,7 +4,7 @@ | |||
| #[macro_use] | |||
| pub mod sub_lib; | |||
|
|
|||
| #[cfg_attr(test, macro_use)] | |||
| //#[cfg_attr(test, macro_use)] | |||
There was a problem hiding this comment.
Should this be deleted?
masqrauder
approved these changes
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.