Fix #8 by removing postgres port map #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don’t need to expose the postgres port on the host. The containers communicate via their own ports on the bridge network. Exposing the postgres port on `5432` can lead to port clashes with existing postgres instances. If we want to expose postgres, we should do it on something like port `54321`, *but* we don’t need to change the connect strings etc elsewhere as they still communicate via `5432` on the bridge network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don’t need to expose the postgres port on the host. The containers communicate via their own ports on the bridge network. Exposing the postgres port on
5432can lead to port clashes with existing postgres instances. If we want to expose postgres, we should do it on something like port54321, but we don’t need to change the connect strings etc elsewhere as they still communicate via5432on the bridge network.It would be good for someone else to verify that this still works before merging.