Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes PDBWriter and PDBReader newlines for PDB header #2325

Merged
merged 8 commits into from
Aug 12, 2019

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Aug 12, 2019

Fixes #2324

Changes made in this Pull Request:

  • Stripped PDB HEADER in PDBReader of newline trailing characters.
  • Stripped PDB HEADER in PDBWriter of newline trailing characters.

I'm not sure which tests need to be added, since PDBReader and PDBWriter should already be tested.

This problem does not really concern MDAnalysis, since it can cope with PDB files containing empty lines.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@RMeli RMeli changed the title Fixes PDBWriters newlines for PDB header Fixes PDBWriter and PDBReader newlines for PDB header Aug 12, 2019
@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #2325 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2325   +/-   ##
========================================
  Coverage    89.75%   89.75%           
========================================
  Files          173      173           
  Lines        21536    21536           
  Branches      2804     2804           
========================================
  Hits         19329    19329           
  Misses        1615     1615           
  Partials       592      592
Impacted Files Coverage Δ
package/MDAnalysis/coordinates/PDB.py 90.63% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7854011...981d16d. Read the comment docs.

Copy link
Member

@richardjgowers richardjgowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RMeli

@richardjgowers richardjgowers merged commit b39796e into MDAnalysis:develop Aug 12, 2019
@RMeli RMeli deleted the bugfix/writepdb branch August 13, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDBWriter adds empty line after header
2 participants