-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to MDA rtd sphinx theme #122
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for link fixing and face-lifting.
Is the content from the removed notebooks available elsewhere?
@orbeckst I just noticed the diff for the notebooks are misleading. The notebooks are still part of the documentation. I had to regenerate them to verify every cell works and the output is correct -the same as before-; the nb kernel was also updated to enable docs build in the CI. Here are the build notebooks in the tutorial section in case you want to check: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for putting in the effort!
@lilyminium, if possible, would you please help me with a quick review here before I merge? |
@ojeda-e apologies I am unlikely to have much time to look at this until the weekeend - please do re-ping me if you still need my input by then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good @ojeda-e, I've just left some comments largely on the notes. I also think you've put last year in the "Last executed" line of docs/source/pages/Curvature_membrane-only_systems.ipynb
(ReviewNB won't let me comment directly....)
Just commenting this review to avoid blocking progress :-)
Thanks for taking the time here @lilyminium |
As we agreed with @IAlibay, I am here submitting changes to update the docs theme to the official one. This PR fixes #120 and #110 (opened by @orbeckst).
Description
Update docs
mdanalysis-sphinx-theme
with plus maintenance.Status
It compiles locally and seems to work as expected. I'll be fixing the issues if any once it build in the CI.
Thanks.