Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getShotDB does not include shots stored in paths with shot digit wildcards #2538

Open
fluffynukeit opened this issue Feb 28, 2023 · 1 comment
Labels
core Relates to the core libraries and scripts priority/backlog

Comments

@fluffynukeit
Copy link
Contributor

https://www.mdsplus.org/index.php/Documentation:TreeAccess

Shot digit wildcards in path specifications like ~a are not processed correctly by getShotDB. ~t does get processed correctly. The code does not look like it makes any attempt to process it.

def getShotDB(expt, path=None, lower=None, upper=None):

The drop down in jTraverser2 also ignores these wildcard paths.

The combinatorics on ~a through ~j with ten possible digits are enormous. I'm not sure that this function could ever be performant and return a complete result, but I hope I am wrong because "what shots exists" is a very reasonable question to ask. Minimally I think the limitation should be documented, perhaps even an automatic warning if getShotDB finds wildcards in the EXPT_path.

@joshStillerman
Copy link
Contributor

joshStillerman commented Feb 28, 2023 via email

@WhoBrokeTheBuild WhoBrokeTheBuild added priority/backlog core Relates to the core libraries and scripts labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Relates to the core libraries and scripts priority/backlog
Projects
None yet
Development

No branches or pull requests

3 participants