Use _TreeCtx object to handle garbage collection and final closing of… #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfredian
added a commit
that referenced
this pull request
Dec 23, 2015
Use _TreeCtx object to handle garbage collection and final closing of…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… tree context
This is a much simpler approach of dealing with garbage collection of the Tree contexts. Each Tree instance now has a _TreeCtx member with is a reference to the tree dbid ctx pointer used by the treeshr c routines. When all references to this ctx pointer are removed the trees opened in that ctx are closed and the ctx is freed. When an lsof is added to the python tests after all trees refs are deleted and garbage collection is done no open tree files are found indicating that the tree contexts were cleaned up properly.