Created methods to parse through the CSV files and create objects #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneemes
reviewed
Jul 31, 2024
Comment on lines
+17
to
+36
| def create_objects(path, statistics, tracker) | ||
| data = CSV.parse(File.read(path), headers: true, header_converters: :symbol) | ||
| data.map { |row| statistics.new(row, tracker) } | ||
| end | ||
|
|
||
| def highest_total_score | ||
| total_score.max | ||
| end | ||
|
|
||
| def lowest_total_score | ||
| total_score.min | ||
| end | ||
|
|
||
| def total_score | ||
| @games.map do |game| | ||
| home_goals = game.home_goals | ||
| away_goals = game.away_goals | ||
| home_goals + away_goals | ||
| end | ||
| end |
There was a problem hiding this comment.
You made great progress on this Melchor! I like the addition of a helper method here, it makes it look very clean.
There was a problem hiding this comment.
I agree. I like this format and think the group should follow suit for the other methods as well. Once we have all of these methods written I think it might make sense to pull out the helper methods (like total_score) into a module file.
TDManning
reviewed
Jul 31, 2024
| @@ -1,10 +1,39 @@ | |||
| require 'csv' | |||
There was a problem hiding this comment.
Note: modify 'requires' as a spec_helper file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the initialize method and the helper method create_objects by passing through each CSV and putting them into an array with hashes in it. So ruby can work with the data much better. Also its converting each header to symbols. Created the Game and teams class so StatTracker knows where to go for the keys of each CSV file.