Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download data from OSF for testing #45

Merged
merged 18 commits into from
Nov 22, 2021
Merged

Download data from OSF for testing #45

merged 18 commits into from
Nov 22, 2021

Conversation

eurunuela
Copy link
Collaborator

Closes #44 .

Changes proposed in this pull request:

  • Remove data directory.
  • Download data from OSF to perform tests.

@eurunuela eurunuela added the Tests Pytest and automatic testing on CircleCI label Feb 12, 2021
@eurunuela eurunuela marked this pull request as ready for review February 21, 2021 11:59
@eurunuela eurunuela mentioned this pull request Nov 19, 2021
@eurunuela
Copy link
Collaborator Author

So, in main we were using different mixing matrices for the integration and unit tests, which was confusing when working on this PR. I have removed duplicates so that there is only one mixing matrix for testing and have updated other benchmark files accordingly.

I think this is now ready to be merged. What do you think @tsalo ?

@eurunuela eurunuela requested a review from tsalo November 22, 2021 18:03
@codecov-commenter
Copy link

Codecov Report

Merging #45 (b561bdb) into main (82f281c) will not change coverage.
The diff coverage is 90.90%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   63.15%   63.15%           
=======================================
  Files           7        7           
  Lines         418      418           
=======================================
  Hits          264      264           
  Misses        154      154           
Impacted Files Coverage Δ
aroma/features.py 93.82% <83.33%> (ø)
aroma/utils.py 90.34% <100.00%> (ø)

aroma/tests/conftest.py Outdated Show resolved Hide resolved
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eurunuela eurunuela merged commit 51664dc into ME-ICA:main Nov 22, 2021
@eurunuela eurunuela deleted the osf branch November 23, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Pytest and automatic testing on CircleCI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move testing data into OSF
3 participants