-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make class accept images instead of arrays #29
Labels
enhancement
New feature or request
Comments
Closed
@eurunuela and @notZaki, I have two questions:
|
Yes, it should be fine. We would need to update the tests though.
I think we should, yes. We could make the class hold both; e.g., |
This was referenced Feb 23, 2021
I'm in favour of using nilearn's functions. I don't know enough to comment on the outputs, but it sounds ok to me---it certainly makes the types more symmetric between input-output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Originally, we wanted to have the function operate on images and the class operate on arrays, in case we could get rid of the spatial elements of the algorithm (see #5). Since that's not possible anymore, the way we pass around a 3D shape tuple and a 1D mask vector is more than a little awkward. We can just move the image-related code from the function to the class and pass in a data image and a mask image to clean up the interface.
The text was updated successfully, but these errors were encountered: