-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop spatial elements from sklearn-style class #5
Comments
If it isn't possible to drop the spatial elements, then we should probably at least try to find the most general set of arguments to use (e.g., a 3D array for the mask instead of both a shape tuple and a mask vector, or possibly something else entirely). |
Per Gitter conversations, our ability to drop the spatial elements of the algorithm will determine if we end up proposing adding it to |
Thank you @tsalo for bringing the Gitter conversation over here. That's right, that's where we stand. |
It doesn't seem like it's possible to remove the spatial elements. I think we can close this. |
Currently we pass around
shape_3d
(a three-element tuple with the shape of the image) andmask_vec
(a 1D array indicating whether a given voxel falls within the mask) throughout theMovingAveragePCA
class, and I would love to support 2D data, if that's possible.The text was updated successfully, but these errors were encountered: