Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Test on 3.11 and 3.12 #999

Merged
merged 3 commits into from
Nov 20, 2023
Merged

MNT: Test on 3.11 and 3.12 #999

merged 3 commits into from
Nov 20, 2023

Conversation

effigies
Copy link
Contributor

@effigies effigies commented Nov 16, 2023

Add GitHub tests for Python 3.11 and 3.12, updating pyproject.toml to reflect support.

While I'm at it, I updated the black target version to Python 3.8 and ran pyupgrade --py38-plus.

For reference, pyupgrade is a small tool to migrate to new syntax or best practices as support windows drop older versions of Python.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a422dc3) 89.54% compared to head (a24c9fe) 89.54%.

Files Patch % Lines
tedana/workflows/tedana.py 25.00% 3 Missing ⚠️
tedana/io.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #999   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          26       26           
  Lines        3395     3395           
  Branches      619      619           
=======================================
  Hits         3040     3040           
  Misses        207      207           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tsalo
tsalo previously approved these changes Nov 20, 2023
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsalo tsalo added testing issues related to improving testing in the project maintenance issues related to versioning, dependencies, and other related elements labels Nov 20, 2023
@effigies
Copy link
Contributor Author

effigies commented Nov 20, 2023

Oops. On my local copy, I ran pyupgrade --py38-plus but didn't push. It got pulled in when I rebased on master. I can roll that back unless you like the changes.

@tsalo
Copy link
Member

tsalo commented Nov 20, 2023

@handwerkerd once we merge this, what do you think about making the new release? It would allow fMRIPrep to start testing on Python 3.12.

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes from pyupgrade all look fine to me, so as long as tests pass I'm happy to approve.

Copy link
Member

@handwerkerd handwerkerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Could you edit the opening comment in the conversation to mention running pyupgrade so that, if we're looking back at this, we'll be able to figure out what happened without digging too much into the conversation thread.

@effigies
Copy link
Contributor Author

Done.

@handwerkerd
Copy link
Member

@tsalo I updated the draft release notes & included this PR. Since we agreed to release a new version at our last dev call, once this is merged, feel free to revise the release notes & then release.

@tsalo tsalo merged commit 1c3f93e into ME-ICA:main Nov 20, 2023
16 checks passed
@effigies effigies deleted the mnt/pyupgrade branch November 20, 2023 22:53
@tsalo
Copy link
Member

tsalo commented Nov 22, 2023

@all-contributors please add @effigies for code.

Copy link
Contributor

@tsalo

I've put up a pull request to add @effigies! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance issues related to versioning, dependencies, and other related elements testing issues related to improving testing in the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants