-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Test on 3.11 and 3.12 #999
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
=======================================
Coverage 89.54% 89.54%
=======================================
Files 26 26
Lines 3395 3395
Branches 619 619
=======================================
Hits 3040 3040
Misses 207 207
Partials 148 148 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
452bd31
to
a24c9fe
Compare
Oops. On my local copy, I ran |
@handwerkerd once we merge this, what do you think about making the new release? It would allow fMRIPrep to start testing on Python 3.12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes from pyupgrade all look fine to me, so as long as tests pass I'm happy to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Could you edit the opening comment in the conversation to mention running pyupgrade
so that, if we're looking back at this, we'll be able to figure out what happened without digging too much into the conversation thread.
Done. |
@tsalo I updated the draft release notes & included this PR. Since we agreed to release a new version at our last dev call, once this is merged, feel free to revise the release notes & then release. |
@all-contributors please add @effigies for code. |
I've put up a pull request to add @effigies! 🎉 |
Add GitHub tests for Python 3.11 and 3.12, updating pyproject.toml to reflect support.
While I'm at it, I updated the
black
target version to Python 3.8 and ranpyupgrade --py38-plus
.For reference, pyupgrade is a small tool to migrate to new syntax or best practices as support windows drop older versions of Python.