Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditch Reclutch for Skulpin #3

Merged
merged 6 commits into from Sep 12, 2020
Merged

Ditch Reclutch for Skulpin #3

merged 6 commits into from Sep 12, 2020

Conversation

ctrlcctrlv
Copy link
Collaborator

@aclysma needs to release a version of aclysma/skulpin#63 upstream so I can push this and ditch Reclutch in master.

Closes #2. CC: @eliheuer

@ctrlcctrlv
Copy link
Collaborator Author

Oh and sorry @jazzfool this reverts #1 and removes Reclutch...because I want to support Mac, so I took you out of AUTHORS file. Thanks for all your help though, and for recommending this move to Vulkan.

@eliheuer
Copy link
Contributor

It works for me on Debian at commit 3c25cea, but on Mac OS 10.15 I get:

Error during renderer construction: CreateInstanceError(LoadingError(LoadingError(DlOpen { desc: "dlopen(libvulkan.dylib, 2): image not found" })))

@ctrlcctrlv
Copy link
Collaborator Author

Known issue :) you have to install the Vulkan SDK on OSX for now. If I ever make a binary release that perhaps won't be the case

@ctrlcctrlv
Copy link
Collaborator Author

I'll document it once I merge this branch, I have some more work to do on it, hopefully tonight, to get it into a mergeable state~

@eliheuer
Copy link
Contributor

Thanks! I'm doing a Twitch stream now looking at the code so far on Debian!
https://www.twitch.tv/eli_gtl

They finally pushed 0.10.0 to crates.io.

This might change. See aclysma/skulpin#66 (GitHub), @aclysma doesn't
like my multiple layer idea and is urging me to vendorize, so I could
end up doing that some day.
@ctrlcctrlv ctrlcctrlv merged commit 7d92c54 into master Sep 12, 2020
@ctrlcctrlv ctrlcctrlv deleted the skulpin branch September 14, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not render correctly on OS X
2 participants