Adding magnitude and phase function #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I reviewed this pull request and it worked for me. It is easy to use. I followed the instructions in this link: MHKiT Example to use MHKiT with WEC-Sim data. I used the function to calculate the magnitude and phase of the data provided in the example. I run the tests and all of them passed. It was the first time I used MHKiT-Python and it was a good experience overall. It is good to have all the resources available on the webpage such as the installation guidelines and the examples, that makes the user experience a lot easier. |
|
@rpauly18 i assume the next step is to write the MATLAB wrapper? LMK when that's ready and we can start using it. Thanks! |
rpauly18
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple function to calculate the magnitude and phase of floats, ints, arrays, or series in 2D or 3D added to the utils module.
@kmruehl do you think you will have time to take a look at this before your vacation?