Request NDBC Station Metadata #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
akeeste
approved these changes
May 10, 2023
There was a problem hiding this comment.
Hi @ssolson
No major changes from me, looks great.
I made a couple minor documentation updates to the example notebooks in ssolson#4. The plot_rose call in the metocean example also has to be updated, since the import into ndbc was removed. I changed the metocean notebook to import the function directly from the tidal module, and reran the notebook to fix an error there. Please merge ssolson#4 into your branch, then we can merge this
* fix minor typos * update plot_rose call in metocean example * rerun metocean example to fix errors
Merged
ssolson
added a commit
that referenced
this pull request
Aug 11, 2023
**MHKiT 0.7.0 Release Notes** This release introduces exciting new features and improvements to the MHKiT package: - **Mooring Module**: We are pleased to introduce the new mooring module. This addition primarily supports outputs from MoorDyn. Within this module, users can: - Import data - Calculate lay length - Visualize mooring line movements in 2D and 3D with graphical animations. Accompanying this module is an example notebook to guide users on its functionalities. - **Dolfyn Module Revamp**: The Dolfyn module has been overhauled. Enhancements include: - Turbulence calculation capability - Performance measures for tidal power as outlined in IEC/TS 6200-200. - **New Contributions**: A big shoutout to our community member, @mbruggs, for adding the ability to compute surface elevation using IFFT. - **NDBC Buoy Metadata**: Users can now fetch NDBC buoy metadata directly through MHKiT. - **Delft3D Module Update**: Stay up to date with support for the latest Delft3D NetCDF format. **Additions** - #235 - #232 - #236 - #250 - #239 - #248 **Bug Fixes** - #226 - #238 **Meta/Minor Changes** - #220 - #243 - #225 - #231 - #224 Thank you to all of the contributers who helpped with this release: @mbruggs @Graham-EGI @castillocesar @jmcvey3 @hivanov-nrel @browniea @cmichelenstrofer @akeeste @maxwelllevin @rpauly18 @ssolson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #76 by adding a function
get_buoy_metadatato the ndbc submodule.This PR adds needed tests and updates the PACWAVE example to show how to call the metadata.