-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
都市オブジェクトの構造体を "Objectify" する仕組み #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files
📢 Thoughts on this report? Let us know! |
ciscorn
force-pushed
the
feature/citygml-objectify
branch
from
December 6, 2023 03:16
0b7ba69
to
8754746
Compare
This was referenced Dec 6, 2023
Closed
nokonoko1203
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ciscorn LGTMです!
が、疑問があったので暇な時にでも回答いただけると嬉しいですー!
ciscorn
force-pushed
the
feature/citygml-objectify
branch
7 times, most recently
from
December 7, 2023 03:25
82fe4c9
to
924ef3e
Compare
ciscorn
force-pushed
the
feature/citygml-objectify
branch
from
December 7, 2023 03:26
924ef3e
to
4f04424
Compare
ciscorn
added a commit
that referenced
this pull request
Dec 27, 2023
Rustの構造体として読み込まれたCityGMLの都市オプジェクトを、より汎化されたデータ型での表現(JSONのようなものをイメージしてもらえれば)に変換できるようにする。これによって後段での加工や、出力ドライバでの扱いができるようになる。 今後も色々とブラッシュアップしていくと思いますが、大枠はこれでいいのでいったんPR投げます。 <img width="484" alt="object" src="https://github.com/MIERUNE/nusamai/assets/5351911/49fa57a7-1b6c-4c89-97ff-9b5904c23045"> Closes #40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rustの構造体として読み込まれたCityGMLの都市オプジェクトを、より汎化されたデータ型での表現(JSONのようなものをイメージしてもらえれば)に変換できるようにする。これによって後段での加工や、出力ドライバでの扱いができるようになる。
今後も色々とブラッシュアップしていくと思いますが、大枠はこれでいいのでいったんPR投げます。
Closes #40