Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix laplacian and degree shape check in laplacian.normalisation #82

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

smoia
Copy link
Collaborator

@smoia smoia commented Nov 2, 2023

Closes #

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) label Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #82 (04fd91c) into master (7a24212) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   90.93%   90.85%   -0.08%     
==========================================
  Files          14       14              
  Lines        1235     1236       +1     
==========================================
  Hits         1123     1123              
- Misses        112      113       +1     
Files Coverage Δ
nigsp/operations/laplacian.py 95.78% <100.00%> (ø)
nigsp/workflow.py 74.43% <0.00%> (-0.34%) ⬇️

@smoia smoia merged commit e1ac636 into MIPLabCH:master Dec 12, 2023
6 of 8 checks passed
@smoia smoia deleted the fix/matchdim branch December 12, 2023 09:30
@smoia
Copy link
Collaborator Author

smoia commented Dec 12, 2023

🚀 PR was released in 0.18.3 🚀

@smoia smoia added the Released This PR has been released! label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) Released This PR has been released!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant