Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaking on datetime parsing #534

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Tweaking on datetime parsing #534

merged 1 commit into from
Jan 31, 2020

Conversation

mokaddem
Copy link
Contributor

  • check for timezone sign after the date field
  • updated *-seen test to avoid errors while testing using python 3.6 (do not support tz=08:00 but do support 0800)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 37.631% when pulling 5277476 on datetime-parsing into 3dddacc on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 37.631% when pulling 5277476 on datetime-parsing into 3dddacc on master.

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #534 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage   37.66%   37.69%   +0.02%     
==========================================
  Files          35       35              
  Lines        7064     7064              
==========================================
+ Hits         2661     2663       +2     
+ Misses       4403     4401       -2
Impacted Files Coverage Δ
tests/testlive_comprehensive.py 0% <0%> (ø) ⬆️
pymisp/mispevent.py 69.68% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dddacc...5277476. Read the comment docs.

@Rafiot Rafiot merged commit 85b4f1d into master Jan 31, 2020
@Rafiot Rafiot deleted the datetime-parsing branch July 7, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants