Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed __query_virustotal return type #562

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Conversation

DocArmoryTech
Copy link
Contributor

__query_virustotal returned a Response object and not the json expected; modified so that report_json is returned instead of report.

__query_virustotal returned a Response object and not the json expected; modified so that report_json is returned instead of report.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 38.024% when pulling 4ee4db1 on DocArmoryTech:patch-1 into 12e05fd on MISP:master.

@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #562 into master will not change coverage by %.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #562   +/-   ##
=======================================
  Coverage   38.07%   38.07%           
=======================================
  Files          35       35           
  Lines        7068     7068           
=======================================
  Hits         2691     2691           
  Misses       4377     4377           
Impacted Files Coverage Δ
pymisp/tools/vtreportobject.py 29.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e05fd...4ee4db1. Read the comment docs.

@Rafiot
Copy link
Member

Rafiot commented Apr 6, 2020

Oh. Your're right, thanks!

@Rafiot Rafiot merged commit 9aab22f into MISP:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants