Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scanner and scanner-query to network-profile object #390

Closed
mFaou opened this issue May 9, 2023 · 6 comments
Closed

Add scanner and scanner-query to network-profile object #390

mFaou opened this issue May 9, 2023 · 6 comments

Comments

@mFaou
Copy link
Contributor

mFaou commented May 9, 2023

Hello,
I'd like to enrich the network-profile object with two attributes:

  • scanner: it would be a string from the following list shodan, censys, zoomeye, onyphe, binaryedge
  • scanner-query: it would contain a query (as a string) in the language of the selected scanner

Do you think it's a good idea to add those two fields in the network-profile object or it would be better to create a new object? Once it is decided, I can do a PR.

Thanks.

@mFaou
Copy link
Contributor Author

mFaou commented Jul 4, 2023

@adulau, any opinion on this?

@mokaddem
Copy link
Contributor

Hello,
Instead of modifying network-profile objects, what do you think of updating scan-result instead?

@mFaou
Copy link
Contributor Author

mFaou commented Jul 19, 2023

good idea. And can I add shodan, censys, etc in the scan-result-tool list?

@mFaou
Copy link
Contributor Author

mFaou commented Jul 28, 2023

PR: #401

@mFaou
Copy link
Contributor Author

mFaou commented Aug 1, 2023

FYI: #402
We'd like to be able to use the object to store the scan-result-query without necessarily attaching a file. For example we will create additional domain-ip objects and link them to this scan-result object.

@mFaou
Copy link
Contributor Author

mFaou commented Sep 12, 2023

Thanks for the merge and release, I'm closing the ticket

@mFaou mFaou closed this as completed Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants