Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify meaning of ID "human-readable identifier" #9

Closed
rooterkyberian opened this issue Mar 6, 2018 · 2 comments
Closed

Clarify meaning of ID "human-readable identifier" #9

rooterkyberian opened this issue Mar 6, 2018 · 2 comments

Comments

@rooterkyberian
Copy link

id represents the human-readable identifier associated to the event for a specific MISP instance.

Currently https://github.com/MISP/MISP project uses integers for IDs, but if I'm reading this correctly this is just implementation specific and any other implementation could put here whatever they wanted (another UUID or slug name or some kind of hash).

@adulau
Copy link
Member

adulau commented Mar 6, 2018

Indeed, the RFC is based on the MISP core implementation. Where the practice is to have an integer represented as a string for the ID. @iglocska what do you think?

@rooterkyberian
Copy link
Author

rooterkyberian commented Mar 6, 2018

If that is the case please it would be good to add the number range constrains. I have read skimmed MISP software source code, but it seems the ID is limited by MySQL int(11) field, i.e. signed 4-byte integer. On PostgreSQL it seems to use twice the bytes for the ID, but MySQL is the default, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants