Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the --no-sign-request argument to avoid loading AWS credentials #2292

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Chrystinne
Copy link
Contributor

This PR modifies the current AWS sync command for downloading open-access projects.

Adding the --no-sign-request argument will avoid loading AWS credentials, as they are not required to access these datasets.

@bemoody bemoody merged commit 93ad99a into dev Sep 16, 2024
8 checks passed
tompollard added a commit that referenced this pull request Sep 29, 2024
Add more detailed instructions to the /settings/cloud/ page.

(Remember that the AWS stuff won't appear on that page unless you set
`AWS_VERIFICATION_BUCKET_NAME` in `.env`.)

It's important to tell people that they need to enable the
`AmazonS3FullAccess` policy. Perhaps that part is obvious to people who
use AWS regularly, but to me it is extremely strange and unintuitive
that if you *create a user with the default settings*:
- That user is allowed to access S3 buckets in its own account, if the
bucket's policy says it's okay.
- That user is *not* allowed to access S3 buckets in other AWS accounts,
regardless of the bucket's policy.

(Pull #2292 addresses another facet of the same issue.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants