Update Lambda Handler Name #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: There is a tight interdependency between the name of the Python function and the file in which that function lives and the Terraform definition of the Lambda that relies on this repository. In order to keep these in sync, we document the naming decision in both this repo and in the Terraform repo and make the appropriate changes See ADR#8 in mitlib-tf-workloads-libraries-website How this addresses that need: * Create an ADR in this repo that captures the name of the function that is the handler function and the name of the .py file that contains that function. * Update the function name in the lambda_edge.py file * In preparation for the full dev/stage/prod workflow, we add the production deploy GitHub workflow
Pull Request Test Coverage Report for Build 7645872395
💛 - Coveralls |
8 tasks
JPrevost
previously approved these changes
Jan 24, 2024
Why these changes are being introduced: There was a discrepancy between the documentation in the production GHA workflow for deploying the app and what the workflow actually did. How this addresses that need: * Fix the comment header for the prod deploy workflow for the Lambda function Side effects of this change: None.
JPrevost
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Align the file naming and function naming with the infrastructure updates in mitlib-tf-workloads-libraries-website PR#50.
Fundamentally, the porimary change here is the name of the Python function in the
lambda_edge.pyfile. The other changes here are updates to the various tests (so that they use the new function name) and an ADR to match up to mitlib-tf-workloads-libraries-website ADR#8.Additionally, we add the prod deploy GitHub Actions workflow.
How can a reviewer manually see the effects of these changes?
This is already deployed in Dev1. This Lambda@Edge function handles the origin-request routing for requests to our "custom domain" CDN. You can verify that this is working correctly by visiting
What happens next
PR#50 has been approved, but not yet merged to
stagenor deployed in Stage-Workloads. There is also the pending cf-lambda-geo-auth PR#2 that needs to be approved. Once all three of these PRs are approved, the following will be the next steps.mainand verify that the updated.zipfile is pushed to theshared-files-xxxxS3 bucket in Stage-Workloads..zipfile is pushed to theshared-files-xxxxS3 bucket in Stage-Workloads.stageand then deploy the updated infrastructure to Stage-Workloads.Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Dev CF Lambda@Edge Full Deployworkflow has been run to update CloudFront in Dev1Code Reviewer(s)