Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE Experimenting for iOS text wrap bug #197

Closed
wants to merge 9 commits into from

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Jun 6, 2024

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@jazairi jazairi changed the title Experimenting with line height for iOS text wrap bug DO NOT MERGE Experimenting with line height for iOS text wrap bug Jun 6, 2024
@mitlib mitlib temporarily deployed to timdex-ui-pi-gdt-246-io-e7xrkl June 6, 2024 16:32 Inactive
@jazairi jazairi changed the title DO NOT MERGE Experimenting with line height for iOS text wrap bug DO NOT MERGE Experimenting with iOS text wrap bug Jun 6, 2024
@jazairi jazairi changed the title DO NOT MERGE Experimenting with iOS text wrap bug DO NOT MERGE Experimenting for iOS text wrap bug Jun 6, 2024
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9404559311

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.653%

Totals Coverage Status
Change from base Build 9321167366: 0.0%
Covered Lines: 586
Relevant Lines: 594

💛 - Coveralls

@jazairi jazairi temporarily deployed to timdex-ui-pi-gdt-246-io-e7xrkl June 6, 2024 16:56 Inactive
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9404867245

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 98.485%

Files with Coverage Reduction New Missed Lines %
app/controllers/search_controller.rb 1 98.11%
Totals Coverage Status
Change from base Build 9321167366: -0.2%
Covered Lines: 585
Relevant Lines: 594

💛 - Coveralls

@jazairi jazairi temporarily deployed to timdex-ui-pi-gdt-246-io-e7xrkl June 6, 2024 17:32 Inactive
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9405318676

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.653%

Totals Coverage Status
Change from base Build 9321167366: 0.0%
Covered Lines: 586
Relevant Lines: 594

💛 - Coveralls

@jazairi jazairi temporarily deployed to timdex-ui-pi-gdt-246-io-e7xrkl June 6, 2024 17:34 Inactive
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9405348974

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.653%

Totals Coverage Status
Change from base Build 9321167366: 0.0%
Covered Lines: 586
Relevant Lines: 594

💛 - Coveralls

@jazairi jazairi temporarily deployed to timdex-ui-pi-gdt-246-io-e7xrkl June 6, 2024 17:43 Inactive
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9405451769

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 98.485%

Files with Coverage Reduction New Missed Lines %
app/controllers/search_controller.rb 1 98.11%
Totals Coverage Status
Change from base Build 9321167366: -0.2%
Covered Lines: 585
Relevant Lines: 594

💛 - Coveralls

@jazairi jazairi temporarily deployed to timdex-ui-pi-gdt-246-io-e7xrkl June 6, 2024 17:46 Inactive
@jazairi jazairi temporarily deployed to timdex-ui-pi-gdt-246-io-e7xrkl June 6, 2024 17:47 Inactive
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9405480060

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 98.485%

Files with Coverage Reduction New Missed Lines %
app/controllers/search_controller.rb 1 98.11%
Totals Coverage Status
Change from base Build 9321167366: -0.2%
Covered Lines: 585
Relevant Lines: 594

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9405493173

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 98.485%

Files with Coverage Reduction New Missed Lines %
app/controllers/search_controller.rb 1 98.11%
Totals Coverage Status
Change from base Build 9321167366: -0.2%
Covered Lines: 585
Relevant Lines: 594

💛 - Coveralls

@jazairi jazairi temporarily deployed to timdex-ui-pi-gdt-246-io-e7xrkl June 6, 2024 17:49 Inactive
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9405511379

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.653%

Totals Coverage Status
Change from base Build 9321167366: 0.0%
Covered Lines: 586
Relevant Lines: 594

💛 - Coveralls

@jazairi jazairi temporarily deployed to timdex-ui-pi-gdt-246-io-e7xrkl June 6, 2024 17:55 Inactive
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9405584248

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.653%

Totals Coverage Status
Change from base Build 9321167366: 0.0%
Covered Lines: 586
Relevant Lines: 594

💛 - Coveralls

@jazairi jazairi temporarily deployed to timdex-ui-pi-gdt-246-io-e7xrkl June 6, 2024 18:02 Inactive
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9405655622

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.653%

Totals Coverage Status
Change from base Build 9321167366: 0.0%
Covered Lines: 586
Relevant Lines: 594

💛 - Coveralls

@jazairi jazairi temporarily deployed to timdex-ui-pi-gdt-246-io-e7xrkl June 6, 2024 19:58 Inactive
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9407038039

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 98.485%

Files with Coverage Reduction New Missed Lines %
app/controllers/search_controller.rb 1 98.11%
Totals Coverage Status
Change from base Build 9321167366: -0.2%
Covered Lines: 585
Relevant Lines: 594

💛 - Coveralls

@jazairi jazairi closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants